Stackoverflow fix in ImageDescriptor#3315
Conversation
|
@akurtakov, do I miss something? PR description says about StackOverflow fix, but code change shows only javadoc comment changed? |
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
FYI, the installer was broken from stack overflow in org.eclipse.emf.edit.ui.provider.ImageWrapperImageDescriptor
I forgot to push that part initially. Should be good now. |
|
FYI, this was the stack overflow 
|
Good, but if that was automated cleanup that redirects from deprecated to non deprecated methods, wouldn't that hit again on next cleanup round? |
Yes, I had the same question. But apparently the cleanup considers the Javadoc to determine the replacement call and @akurtakov tested that the changes to the Javadoc prevents the save action (automated by the cleanup bot) from making that change again. We should keep and eye on this nevertheless! |
Fixes getImageData(100) calling itself endlessly (introduced via eclipse-platform@c2fe144 ) by reintroducing the bigger getImageData(100) and getImageData() endlessly (introduced in 2017 via eclipse-platform@e6d12ca ) that wasn't experienced thanks to the *happy accident* that it was asbtract method and all implementations before that had their own and every implementor since then most likely figured the endless loop while developing. Enhanced documentation to mention that.
|
Save action runs that changes deprecated calls relies on deprecated javadoc tag content (https://github.com/eclipse-jdt/eclipse.jdt.ui/blob/210f65acc02641c0e26a081aa88ca119c4c2b2ca/org.eclipse.jdt.core.manipulation/common/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessorUtil.java#L591 ) which explicitly kicks in only for "use" and "replace by" thus I changed the javadoc to "replace with" for the sake of differing. |
Hmm... Next time someone will change javadoc & face same issue again. @jjohnstn : would it be possible to exclude automated replacement of deprecated methods via some kind of "do_not_fix_me" tag on the code that uses deprecated method? |
|
@akurtakov javaodc of the class says:
So does this javadoc needs fixing? |
|
IMO one could drop the note about reimplement exactly one but I haven't given it enough thought. I'm merging this one to prevent the regression and starting new I-build. Documentation enhancement can happen in follow up PRs. |
|
Ongoing build is https://ci.eclipse.org/releng/job/Builds/job/I-build-4.38/40/ . |
|
Thank you. ❣️ |
4 participants
Fixes getImageData(100) calling itself endlessly (introduced via c2fe144 ) by reintroducing the bigger getImageData(100) and getImageData() endlessly (introduced in 2017 via
e6d12ca ) that wasn't experienced thanks to the happy accident that it was asbtract method and all implementations before that had their own and every implementor since then most likely figured the endless loop while developing.
Enhanced documentation to mention that.